Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CodeMirror over Highlightr #70

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Support CodeMirror over Highlightr #70

wants to merge 4 commits into from

Conversation

NghiaTranUIT
Copy link

@NghiaTranUIT NghiaTranUIT commented Nov 3, 2020 •
edited

What's it?

This PR attempts using CodeMirror-Swift over Highlightr because it's better performance.

Relationship

Fix #49

Changelog

  • Remove Highlighter pod and old logic
  • Support CodeMirror
  • Improve CodeMirror dark and light theme

How to review

  • Build this PR and make sure it shows the JSON body as expected

Screenshots

Screen Shot 2020-11-03 at 12 58 08

Screen Shot 2020-11-03 at 12 57 43

@NghiaTranUIT NghiaTranUIT mentioned this pull request Nov 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Large JSON responses
1 participant
@NghiaTranUIT