Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce support for Infinity #72

Merged
merged 3 commits into from Feb 16, 2020
Merged

Conversation

vthibault
Copy link
Contributor

This adds support for Infinity value (previously converted to null).

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@papb
Copy link

papb commented Feb 12, 2020

How about -Infinity?

@vthibault
Copy link
Contributor Author

Nice catch ! Just implemented on 4599ec6.

});

it('should deserialize a map', function () {
var m = eval(serialize(new Map([
['a', 123],
[null, 456]
[null, 456],
[Infinity,322]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be 789 to match the above regularity.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I failed to notice the sequential suit. Here you are: 6ac6afe

@okuryu okuryu merged commit eed510c into yahoo:master Feb 16, 2020
@okuryu
Copy link
Collaborator

okuryu commented Feb 16, 2020

Published v3.0.0. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants