New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating to v2.0.0 breaks building of a create-react-app application #53
Comments
Related issue yahoo/react-stickynode#111 |
Hi, I just updated to 2.0.2 but still caught the error of using I believe these 2 files |
The |
Thanks for response. I created a demo to show it: https://gist.github.com/houkanshan/8b2734c61b4b1ef7055a951a082db020
According to the rollup's doc:
and the discussion on webpack, I believe currently the |
webpack use (I've used react-stickynode. it break old browser for the above reason) Currently, I've used a workaround for this issue.
module.exports = {
// ...cut...
alias: {
'subscribe-ui-event': path.join(__dirname, `node_modules/subscribe-ui-event/index.js`)
)
}
} |
@azu , yes, Webpack use "module" field by default because they are following the Rollup's proposal about But I had checked Anyway, this is my workaround: {
loader: 'babel-loader',
test: /\.jsx?$/,
exclude: {
test: [
path.resolve(__dirname, '../node_modules'),
path.resolve(__dirname, '../bower_components'),
],
exclude: /subscribe-ui-event/,
},
}, It informs the developers that " |
is this fixed?. It happen on my project too. Can't build the project. |
I had to downgrade react-stickynode because of this. |
what about adding a browser field with no |
@houkanshan tried code above, did not change that const was still in the file. |
@roderickhsiao can this be closed now? or we still have an issue? |
It seems like the build error is gone, now the issue is the I think we could just replace |
Yes please |
@redonkulus could close this :) |
Updating to
v2.0.0
breaks the production build of an app created withcreate-react-app
.The text was updated successfully, but these errors were encountered: