Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to distinguish between boxed and primitive types by nullability #39

Open
Jeffset opened this issue Apr 1, 2023 · 0 comments
Open
Labels
backend:ksp Related to KSP backend performance Performance issue/enhancement priority:minor Issue with minor priority.

Comments

@Jeffset
Copy link
Collaborator

Jeffset commented Apr 1, 2023

In order to correctly override methods in Java code in KSP mode, Yatagan uses KSP's experimental APIs to obtain JVM signatures to distinguish between boxed/unboxed java types (e.g. java.lang.Integer vs int).
As per google/ksp#870 (comment), there can be no need for that, nullability info alone may be sufficient to make the distinction.

Let's give it a shot. If it's indeed possible, removing cumbersome JVM-signature obtaining/parsing will greatly simplify the implementation while likely improving performance.

@Jeffset Jeffset added backend:ksp Related to KSP backend performance Performance issue/enhancement labels Apr 1, 2023
@Jeffset Jeffset added this to the 2.0.0 milestone Apr 1, 2023
@Jeffset Jeffset added the priority:minor Issue with minor priority. label Apr 3, 2023
@Jeffset Jeffset removed this from the 2.0.0 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:ksp Related to KSP backend performance Performance issue/enhancement priority:minor Issue with minor priority.
Projects
None yet
Development

No branches or pull requests

1 participant