Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance project structure with angular modules #51

Open
yannbf opened this issue Oct 9, 2017 · 1 comment
Open

Enhance project structure with angular modules #51

yannbf opened this issue Oct 9, 2017 · 1 comment

Comments

@yannbf
Copy link
Owner

yannbf commented Oct 9, 2017

I'm submitting a ... (check one with "x")

[ ] bug report
[ ] feature request
[x] support request

Important information:
The project needs to be better organized in terms of code architecture. It should follow good angular practices so it would have a module for components, another for pipes, etc.

Any discussion is greatly appreciated, this way the project could be used as reference for good practices in Angular, but right now it needs to be better worked on.

@mfdeveloper
Copy link

mfdeveloper commented Apr 24, 2018

Yeah!! Use these components directly into a ionic app structure folder is awful. Each component should be a npm package in node_modules folder, following Feature module angular practice. You can use ng-packagr for this. See this guide: Building an Angular 4 Component Library with the Angular CLI and ng-packagr

Ps: Be careful with AOT problems dherges/ng-packagr#344. Like this repo use Angular 5+, I think that doesn't happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants