Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsx-no-target-blank crashes on empty rel attribute #1269

Closed
not-an-aardvark opened this issue Jun 23, 2017 · 0 comments
Closed

jsx-no-target-blank crashes on empty rel attribute #1269

not-an-aardvark opened this issue Jun 23, 2017 · 0 comments

Comments

@not-an-aardvark
Copy link

Using eslint@4.0.0 and eslint-plugin-react@7.1.0, the jsx-no-target-blank rule crashes on the following code:

<a href="https://example.com" target="_blank" rel />

This can be reproduced with:

echo '<a href="https://example.com" target="_blank" rel />' | node_modules/.bin/eslint --stdin --no-eslintrc --plugin=react --parser-options='ecmaFeatures: {jsx: true}' --rule 'react/jsx-no-target-blank:error'

This is a very minor issue, since I don't know of a good use case for having an empty rel attribute. I only noticed it because a crash notification appeared in my editor.

dustinsoftware added a commit to dustinsoftware/eslint-plugin-react that referenced this issue Jun 24, 2017
dustinsoftware added a commit to dustinsoftware/eslint-plugin-react that referenced this issue Jun 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants