no-literals: only check strings

[davidyorr]

should the no-literals rule check if the node.value is a string? with the new { "noStrings": true } option (#1202) I'm getting errors for explicitly set boolean and number props booleanprop={true} numberprop={100}

[ljharb]

With that option turned off, do you still see the errors?

If enabling the option creates new warnings for non-strings, then yes, that's a bug.

[davidyorr]

with { "noStrings": false } the errors are not there. i can fix it by adding the type check and submit a PR

[ljharb]

Thanks, that'd be great!

[davidyorr]

#1302

[davidyorr]

oh i put the wrong issue # in the commit message -__-

[davidyorr]

ok i fixed it, let me know if there's anything i need to change