New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no-unused-state
rule doesn't handle dynamic keys
#1361
Labels
Comments
I agree that this is a bug - it should entirely ignore computed property keys when the contents aren't a string literal. |
@EvHaus it seems like this can be closed? (linked PR is merged) |
@jseminck Indeed. Closing! |
This was referenced Sep 22, 2018
This was referenced Oct 25, 2018
1 task
1 task
1 task
This was referenced Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@wbinnssmith The following code:
Gives out an
Unused state field: 'stateName'
error from theno-unused-state
rule.I think it's probably best to have
no-unused-state
rule ignore dynamic object keys since it will be too difficult to detect whether or not they're really being used. But at the very least, it shouldn't use the variable name as the key to look for.The text was updated successfully, but these errors were encountered: