Invalid react/no-direct-mutation-state in constructor

[emmanuelgautier]

In the following special case, the react/no-direct-mutation-state rule throw an invalid error

class OneComponent extends Component {
  constructor() {
    super();

    class AnotherComponent extends Component {
      constructor() {
        super();
      }
    }

    this.state = {};
  }
}

A better way is to not declare a component into another component constructor but that is an invalid linter error .

[ljharb]

What error is thrown?

[emmanuelgautier]

Error thrown : Do not mutate state directly. Use setState() react/no-direct-mutation-state

[ljharb]

This seems like a bug - although I can't conceive of why you'd want to create a component in the constructor like that.

[emmanuelgautier]

I agree with you, this code is not mine. It should be a closure problem to have access into the AnotherComponent to some variables declared in the first constructor

[ma-alexiou]

I know I am late to the party, but you have made a typo at the constructor of OneComponent class. Changing contructor to constructor removes the eslint warning.

In your case eslint treats contructor as it would with any other method of OneComponent's class and it warns you that you should not mutate the state this way and use the setState method.