New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jsx no bind rule #1444
Labels
Comments
Yes, that should also warn, if possible. |
This was referenced Dec 15, 2017
This was referenced Sep 22, 2018
Open
This was referenced Oct 25, 2018
1 task
1 task
1 task
1 task
This was referenced Dec 21, 2018
This was referenced Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The no bind rule flags of the following jsx code.
How ever if i modify the same function
The error is not thrown, how ever effectively the same thing of creating a new function when the
renderButton
method is called takes place, only in the second case a separate variable has been assigned. But in terms of memory allocation a new function is being created in both cases and though the rule will give a sign off it'll still not impact performance.Proposal
Modify the scope of the rule to see if bind is called within that function scope..
I may be completely wrong in some assumptions but would like a discussion here , if possible.
The text was updated successfully, but these errors were encountered: