Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template string with special character are getting inappropriately autofix to quoted string #1479

Closed
riwu opened this issue Oct 16, 2017 · 2 comments · Fixed by #1458
Closed

Template string with special character are getting inappropriately autofix to quoted string #1479

riwu opened this issue Oct 16, 2017 · 2 comments · Fixed by #1458
Labels
bug help wanted

Comments

@riwu
Copy link

riwu commented Oct 16, 2017

<input placeholder={`line1\nline2`} ></input> gets autofix into
<input placeholder="line1\nline2" /> which treats the \n literally.

Versions:
"eslint-config-airbnb": "^16.0.0",
"eslint-plugin-import": "^2.7.0",
"eslint-plugin-jsx-a11y": "^6.0.2",
"eslint-plugin-react": "^7.4.0"
@ljharb
Copy link
Member

ljharb commented Oct 17, 2017

cc @jackyho112

@jackyho112
Copy link
Contributor

jackyho112 commented Oct 17, 2017 •
edited

@ljharb Thanks for tagging me! I think this bug will be fixed in this PR because, with this update, the rule will identify the backslash and bail out instead of incorrectly fixing the code.

@jackyho112 jackyho112 mentioned this issue Oct 17, 2017
Merged
@dependencies dependencies bot mentioned this issue Nov 19, 2017
Merged
@lydell lydell mentioned this issue Nov 21, 2017
Closed
This was referenced Dec 15, 2017
Open
Closed
@dependencies dependencies bot mentioned this issue Mar 1, 2018
Open
This was referenced Sep 22, 2018
Closed
Closed
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Closed
Open
Open
This was referenced Oct 25, 2018
Merged
Open
@renovate renovate bot mentioned this issue Nov 7, 2018
Merged
@renovate renovate bot mentioned this issue Nov 23, 2018
Open
1 task
@renovate renovate bot mentioned this issue Dec 5, 2018
Closed
1 task
@mesosphere-web mesosphere-web mentioned this issue Dec 19, 2018
Closed
1 task
This was referenced Dec 21, 2018
Open
Merged
Closed
This was referenced Jan 2, 2019
Merged
Closed
Open
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Milestone
No milestone
3 participants
@ljharb @riwu @jackyho112