Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing documentation #1546

Closed
nwoltman opened this issue Nov 19, 2017 · 4 comments · Fixed by #1549
Closed

Missing documentation #1546

nwoltman opened this issue Nov 19, 2017 · 4 comments · Fixed by #1549

Comments

@nwoltman
Copy link

There is no documentation for the jsx-one-expression-per-line rule (#1497).

Also, the readme is missing a link to the documentation for the button-has-type rule (#1525).

@jseminck
Copy link
Contributor

Thanks for reporting this! I added the link to button-has-type rule.

@TSMMark since you wrote the code for the jsx-one-expression-per-line rule, would you be willing to add the documentation as well?

@TSMMark
Copy link
Contributor

TSMMark commented Nov 19, 2017

Sure thing. Anything I need to do other than the following?

  • add a file in docs/rules/
  • update readme with a link

@jseminck
Copy link
Contributor

That's it 👍

@TSMMark
Copy link
Contributor

TSMMark commented Nov 19, 2017

See #1552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants