Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-deprecated - React.addons.TestUtils doesn't create a warning #1644

Closed
nirnaor opened this issue Jan 14, 2018 · 3 comments · Fixed by #1645
Closed

no-deprecated - React.addons.TestUtils doesn't create a warning #1644

nirnaor opened this issue Jan 14, 2018 · 3 comments · Fixed by #1645
Labels
enhancement help wanted

Comments

@nirnaor
Copy link
Contributor

nirnaor commented Jan 14, 2018

When using React.addons.TestUtils a warning should be thrown, since the addons entry point is deprecated as of 15.5.0 (as per the official documentation)

The error that should be thrown is:
React.addons.TestUtils is deprecated since React 15.5.0, use ReactDOM.TestUtils instead.
@nirnaor nirnaor mentioned this issue Jan 14, 2018
Merged
@ljharb
Copy link
Member

ljharb commented Jan 14, 2018

Thanks! We'll want to make sure that only throws when the version pragma is 15.5.0 or greater.

@nirnaor
Copy link
Contributor Author

nirnaor commented Jan 15, 2018

@ljharb Great. Anything I can do to help with this verification?

@ljharb
Copy link
Member

ljharb commented Jan 15, 2018

Nope, your PR seems solid :-)

This was referenced Jan 26, 2018
Closed
Merged
Closed
Closed
@dependencies dependencies bot mentioned this issue Mar 1, 2018
Open
@renovate renovate bot mentioned this issue Mar 22, 2018
Merged
This was referenced Sep 22, 2018
Closed
Closed
Closed
Open
Merged
Open
Open
Open
Merged
Open
Open
Open
Merged
Open
Open
Closed
Open
This was referenced Sep 23, 2018
Open
Open
Merged
Open
This was referenced Oct 25, 2018
Merged
Open
This was referenced Nov 7, 2018
Merged
Open
This was referenced Nov 23, 2018
Open
Merged
@renovate renovate bot mentioned this issue Dec 5, 2018
Closed
1 task
@mesosphere-web mesosphere-web mentioned this issue Dec 19, 2018
Closed
1 task
This was referenced Dec 21, 2018
Open
Merged
Merged
Closed
This was referenced Jan 2, 2019
Merged
Closed
Open
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding a warning for React.addons.TestUtils. nirnaor/eslint-plugin-react
2 participants
@ljharb @nirnaor