Rule react/destructruring-assignement in a constructor

[mathieug]

The rule react/destructruring-assignement should not throw in a component constructor.

[ljharb]

I’m confused why you’d mutate the object after assigning it (it’s much slower and messier), but yes, this is a bug - specifically, it shouldn’t warn on LHS member chains off of state or props, only RHS.

[mathieug]

I need to condition which attribute I set in the state.

[leohxj]

same as.

[ljharb]

@leohxj in that case, it’s correct. Do const { name } = this.props; before the state assignment, and do both in the constructor (iow, don’t do things in class property initializers that depend on props or state)

[leohxj]

@ljharb

ok, but why "don’t do things in class property initializers that depend on props or state" ?
I think Class properties transform can do this.

[ljharb]

@leohxj of course it will work; the reason not to do it is because it makes things much less clear when reading the code.