Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sort-comp for React 16.3+ #1767

Closed
webOS101 opened this issue Apr 12, 2018 · 3 comments
Closed

Update sort-comp for React 16.3+ #1767

webOS101 opened this issue Apr 12, 2018 · 3 comments

Comments

@webOS101
Copy link
Contributor

The sort-comp rule will need to be updated to include the new lifecycle methods (while also keeping the older ones, optionally?). These include:

getDerivedStateFromProps
getSnapshotBeforeUpdate
UNSAFE_componentWillMount
UNSAFE_componentWillReceiveProps
UNSAFE_componentWillUpdate
@otakustay
Copy link

Also, componentDidCatch is not listed in current sort-comp rule

@dejoean
Copy link
Contributor

dejoean commented Apr 18, 2018

I made an attempt to add this feature with #1771

Would love to hear any feedback/suggestions

@ljharb
Copy link
Member

ljharb commented Apr 26, 2018

Closed in #1771.

@ljharb ljharb closed this as completed Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants