We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can someone explain for me why it is neccessary to check for CallExpressions in here: https://github.com/yannickcr/eslint-plugin-react/blob/master/lib/rules/jsx-sort-default-props.js#L133
I want to help and contribute to this project having full coverage.
The text was updated successfully, but these errors were encountered:
cc @b0gok
Sorry, something went wrong.
@hornta I think it's an artifact from here (where it's necessary of course): https://github.com/yannickcr/eslint-plugin-react/blob/master/lib/rules/sort-prop-types.js#L156
In case of regular props it was added for this case for example:
class First extends React.Component { render() { return <div />; } } First.propTypes = forbidExtraProps({ a: PropTypes.any, z: PropTypes.string, onFoo: PropTypes.func, onBar: PropTypes.func });
When there is a callback around props definition. I'm not sure if this is necessary in case of default props.
👍 for attentiveness.
sort-default-props
jsx-sort-default-props
Add sort-default-props and deprecate jsx-sort-default-props
e212430
Pt. 1 of jsx-eslint#1834 Also fixes jsx-eslint#1817
35e323f
No branches or pull requests
Can someone explain for me why it is neccessary to check for CallExpressions in here:
https://github.com/yannickcr/eslint-plugin-react/blob/master/lib/rules/jsx-sort-default-props.js#L133
I want to help and contribute to this project having full coverage.
The text was updated successfully, but these errors were encountered: