Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-will-update-set-state not reporting for UNSAFE_ version #1844

Closed
lukeapage opened this issue Jun 23, 2018 · 2 comments
Closed

no-will-update-set-state not reporting for UNSAFE_ version #1844

lukeapage opened this issue Jun 23, 2018 · 2 comments
Labels
enhancement help wanted react 16

Comments

@lukeapage
Copy link
Contributor

the rule no-will-update-set-state

stops reporting problems if you rename to the UNSAFE_ version of no will update set state
@alexzherdev
Copy link
Contributor

@ljharb I'm assuming this should only turn on under react 16.3 or higher?

@ljharb
Copy link
Member

ljharb commented Jun 23, 2018

@alexzherdev yep!

alexzherdev added a commit to alexzherdev/eslint-plugin-react that referenced this issue Jun 24, 2018
@alexzherdev
Account for UNSAFE_ method in no-will-update-set-state
3cb8d0d 
Resolves jsx-eslint#1844
@alexzherdev alexzherdev mentioned this issue Jun 24, 2018
Merged
alexzherdev added a commit to alexzherdev/eslint-plugin-react that referenced this issue Jun 24, 2018
@alexzherdev
Account for UNSAFE_ method in no-will-update-set-state
40c4ffa 
Resolves jsx-eslint#1844
ljharb pushed a commit to alexzherdev/eslint-plugin-react that referenced this issue Jun 24, 2018
@alexzherdev @ljharb
Account for UNSAFE_ method in no-will-update-set-state
8122c8b 
Resolves jsx-eslint#1844
calebeby pushed a commit to Pigmice2733/scouting-frontend that referenced this issue Jun 30, 2018
@renovate @calebeby
Update dependency eslint-plugin-react to v7.10.0 (#201)
3cf17b6 
This Pull Request updates dependency [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from `v7.9.1` to `v7.10.0`



<details>
<summary>Release Notes</summary>

### [`v7.10.0`](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md#&#8203;7100---2018-06-24)
[Compare Source](jsx-eslint/eslint-plugin-react@v7.9.1...v7.10.0)
##### Added
* Allow eslint ^5 ([#&#8203;1843][] @&#8203;papandreou, @&#8203;ljharb)
* [`no-unsafe`][] rule ([#&#8203;1831][], [#&#8203;1830][] @&#8203;sergei-startsev)
* [`no-will-update-set-state`][]: Account for `UNSAFE_` methods ([#&#8203;1845][], [#&#8203;1844][] @&#8203;alexzherdev)
##### Fixed
* [`no-typos`][]: Fix static propTypes handling ([#&#8203;1827][], [#&#8203;1677][] @&#8203;alexzherdev)
* [`destructuring-assignment`][]: Allow LHS ([#&#8203;1825][], [#&#8203;1728][] @&#8203;alexzherdev)
* [`no-unused-prop-types`][]: Fix crash when encountering mixed union and intersection flow types ([#&#8203;1806][] @&#8203;yannickcr)
##### Changed
* Typo fixes in [`jsx-no-target-blank`][] ([#&#8203;1805][] @&#8203;ferhatelmas))

[#&#8203;1845]: `jsx-eslint/eslint-plugin-react#1845
[#&#8203;1844]: `jsx-eslint/eslint-plugin-react#1844
[#&#8203;1843]: `jsx-eslint/eslint-plugin-react#1843
[#&#8203;1831]: `jsx-eslint/eslint-plugin-react#1831
[#&#8203;1830]: `jsx-eslint/eslint-plugin-react#1830
[#&#8203;1827]: `jsx-eslint/eslint-plugin-react#1827
[#&#8203;1825]: `jsx-eslint/eslint-plugin-react#1825
[#&#8203;1806]: `jsx-eslint/eslint-plugin-react#1806
[#&#8203;1805]: `jsx-eslint/eslint-plugin-react#1805
[#&#8203;1728]: `jsx-eslint/eslint-plugin-react#1728
[#&#8203;1677]: `jsx-eslint/eslint-plugin-react#1677

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).
@dependencies dependencies bot mentioned this issue Jul 9, 2018
Closed
@dependencies dependencies bot mentioned this issue Aug 1, 2018
Open
This was referenced Sep 22, 2018
Open
Closed
Closed
Open
Open
Closed
Open
Closed
Open
Open
Open
Merged
Closed
Closed
Open
Merged
Open
This was referenced Sep 23, 2018
Closed
Open
Merged
Open
Open
Closed
@renovate renovate bot mentioned this issue Oct 15, 2018
Merged
This was referenced Oct 25, 2018
Merged
Open
Merged
@dependencies dependencies bot mentioned this issue Nov 1, 2018
Closed
This was referenced Nov 4, 2018
Closed
Merged
Open
This was referenced Nov 23, 2018
Open
Merged
@renovate renovate bot mentioned this issue Dec 5, 2018
Closed
1 task
@mesosphere-web mesosphere-web mentioned this issue Dec 19, 2018
Closed
1 task
@renovate-bot renovate-bot mentioned this issue Dec 19, 2018
Merged
1 task
This was referenced Dec 21, 2018
Open
Merged
Merged
Closed
Merged
Closed
This was referenced Jan 2, 2019
Merged
Closed
Open
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted react 16
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ljharb @alexzherdev @lukeapage