Destructuring 'prop-types' results in "no-typos" False Positive

[r-mc2]

(I took a look at other open issues here and found some related but none pointing at exactly this)

I prefer to destructure the exact types I need from the prop-types package rather than pull the whole thing in and dot-syntax to what I need. This seems to be a missing case in the rule file where it only makes two assumptions:

• Importing from the new package: import PropTypes from 'prop-types';
• Importing from the old react package: import { PropTypes } from 'react';

In my case I go with:

import { string, element } from "prop-types";

class Sample {
 ...
}

Sample.propTypes = {
  title: string.isRequired,
  body: element.isRequired
};

Both of the above cause a "Typo in declared prop-type: isRequired". Which in digging through the code makes sense as it appears that because I do not use PropTypes.string.isRequired it is looking for isRequired inside the known types list in the prop-types. And when not found in its iteration the test fails and I get the false-positive.

I'm not entirely sure how to add support for this use-case of prop-types but I'm pretty sure it's this if-block that would also need some work as this is where the logic is falling through to test string.isRequired with the same check responsible for testing PropTypes.string.

[ljharb]

I'm going to assume that Sample extends React.Component or else it wouldn't be detected as a component?

[ljharb]

I've added passing test cases to master. If you can provide more info such that I can reproduce the failure, I'll be happy to reopen this - otherwise it might be fixed on master but unreleased.

[r-mc2]

Thanks for looking into this.

Threw together a quick gist to demonstrate better what I'm working with when the no-typos pops up.

And a screenshot from my editor:

Also should have included my version number for you last time, apologies:
"eslint-plugin-react": "7.4.0",

[ljharb]

Ah, well that’s ancient :-) can you update it from 7.4 to 7.12.4 and try again?

[r-mc2]

Hey, sorry for the delay in getting back to you, but yes updating to latest (7.12.4) did resolve the false-positive. Thanks, Jordan!