Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix]: improve algorithm to check if a variable is coming from the pragma #2706

Merged
merged 1 commit into from Jul 10, 2020
Merged

[Fix]: improve algorithm to check if a variable is coming from the pragma #2706

merged 1 commit into from Jul 10, 2020

Conversation

jzabala
Copy link
Contributor

@jzabala jzabala commented Jul 9, 2020

Improve isDestructuredFromPragmaImport algorithm to more accurately recognize variables coming from the pragma.

Fixes #2164

@ljharb ljharb force-pushed the fix/improve-variable-from-pragman-algorithm branch from 8241fdf to e3e767b Compare July 10, 2020 23:05
@ljharb ljharb merged commit e3e767b into jsx-eslint:master Jul 10, 2020
@jzabala jzabala mentioned this pull request Jul 12, 2020
Closed
@jzabala jzabala deleted the fix/improve-variable-from-pragman-algorithm branch August 13, 2020 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

react/no-multi-comp false positives when declare class property memo keyword
2 participants
@jzabala @ljharb