Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix]: improve component declared props detection #2755

Merged
merged 1 commit into from Aug 14, 2020
Merged

[Fix]: improve component declared props detection #2755

merged 1 commit into from Aug 14, 2020

Conversation

jzabala
Copy link
Contributor

@jzabala jzabala commented Aug 13, 2020

Fixes #2752

ljharb
ljharb reviewed Aug 13, 2020
View reviewed changes
lib/util/common.js Outdated Show resolved Hide resolved
@jzabala jzabala force-pushed the fix/improve-component-declared-props-detection branch 2 times, most recently from 5dee66d to 3b29d23 Compare August 14, 2020 01:18
@jzabala jzabala requested a review from ljharb August 14, 2020 01:33
@ljharb ljharb force-pushed the fix/improve-component-declared-props-detection branch from 3b29d23 to 97ac0fa Compare August 14, 2020 05:00
@ljharb ljharb merged commit 97ac0fa into jsx-eslint:master Aug 14, 2020
@nelsonprsousa
Copy link

Thanks for fixing the bug we reported #2752
❤️

@jzabala jzabala deleted the fix/improve-component-declared-props-detection branch August 14, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive react/no-unused-prop-types
3 participants
@jzabala @nelsonprsousa @ljharb