Fix void-dom-elements-no-children crash #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 27, 2017 15:29
React.createElement() crashes the linter since first argument is undefined.
ljharb
approved these changes
May 27, 2017
| @@ -54,6 +54,10 @@ ruleTester.run('void-dom-elements-no-children', rule, { | |||
| }, { | |||
| code: 'React.createElement("img");' | |||
| }, { | |||
| code: 'React.createElement();' | |||
There was a problem hiding this comment.
I feel like this shouldn't be valid; altho maybe this rule shouldn't be handling it.
There was a problem hiding this comment.
Yup, a different rule that checks for required parameters to React methods would be good. Maybe it could even give a hint on the order and nature of the parameters without needing to go to the docs.
|
Thanks! |
1 task
This was referenced Sep 22, 2018
This was referenced Oct 25, 2018
1 task
1 task
1 task
This was referenced Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React.createElement()currently crashes the linter with the following error and linting doesn't happen:Of course
React.createElement()will cause a runtime error, but it shouldn't crash the linter.