Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] jsx-pascal-case: false negative with namespacing #1337

Merged
merged 1 commit into from Jan 7, 2020

Conversation

mfyuce
Copy link

@mfyuce mfyuce commented Jul 31, 2017

case #1334 - false negative with namespacing/qualifications using jsx-pascal

case #1336 - false postive with names starting with a number using jsx-pascal
[Can besaid it is fixed, but inside it is not accepted anyway. Seems just fixed the regex]

@ljharb
Copy link
Member

ljharb commented Jul 31, 2017

#1336 is not an issue; identifiers can not start with numbers.

tests/lib/rules/jsx-pascal-case.js Outdated Show resolved Hide resolved
@ljharb
Copy link
Member

ljharb commented Dec 30, 2019

@mfyuce any interest in completing this PR?

@ljharb ljharb changed the title case #1334 - case #1336 [Fix] jsx-pascal-case: false negative with namespacing Jan 7, 2020
@ljharb ljharb merged commit 5fac02c into jsx-eslint:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants