require-default-props - fixing an edge case where linting stops early #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jseminck
reviewed
Aug 17, 2017
| @@ -1306,7 +1306,26 @@ ruleTester.run('require-default-props', rule, { | |||
| column: 3 | |||
| }] | |||
| }, | |||
|
|
|||
| // | |||
| // component with no pros followed by a failing component | |||
There was a problem hiding this comment.
Typo.
Also is the empty // needed?
There was a problem hiding this comment.
I was just following the pattern in the rest of the file, I have deleted it now though, since it does seem unnecessary 👍
jseminck
reviewed
Aug 17, 2017
| // component with no pros followed by a failing component | ||
| { | ||
| code: [ | ||
| 'var ComponentWithNoProps = ({ bar = "bar" }) => {', |
There was a problem hiding this comment.
It reads a bit confusing. It says component with no props, but this component actually has two props: bar and foo. I guess that you actually mean; component with no declared prop types (since there is no .propTypes) for the first component.
There was a problem hiding this comment.
updated the comment and fixed typo:
"component with no declared props followed by a failing component"
|
Nice find! The fix looks good to me. I added a few comments about the tests. |
…it finds a component without props - should move on to the next component in the file
ljharb
approved these changes
Aug 17, 2017
1 task
This was referenced Sep 22, 2018
This was referenced Oct 25, 2018
1 task
1 task
1 task
This was referenced Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix an edge case where linting stops when it finds a component without props. Instead it should move on to the next component in the file.