Refactor a bunch of tests to use template literal syntax instead of [].join(

[jseminck]

I wanted to experiment writing a code mod and decided to write one to transform the code: [].join('\n'); syntax to use template literals instead.

I ran it on a file by file basis. I could not transform all the files yet because template literals introduce the following issues:

• Error lines / columns are different. Since my syntax adds 1 extra line + a lot of indentation, those numbers change
• Output often also doesn't work because of the added indentation in the code through the template literal sting

But a lot of files didn't rely on this so at least we could start with transforming those 😄

Here's the codemod code: https://astexplorer.net/#/gist/000b6e8110a245ca6384c260b954e452/1687ee893085fdae7119c809294e5ed43a3fe428

[ljharb]

looks like your codemod removed a bunch of comments. please restore them all

[jseminck]

Woops! My bad... I found the mistake 😄 I'll re-add all of them. I think most are actually in this rule where every test has a comment.

[ljharb]

LGTM; it'd be good to rebase and re-run the codemod, just in case

[ljharb]

@jseminck would you mind one more rebase and rerun? Please ping me when its done and I'll merge asap. Thanks!

[sergeysova]

@ljharb @jseminck maybe squash and merge?

[ljharb]

@lestad a) the issue is with staleness, not with "i only want one commit", b) github's squashmerge and rebase merge are terrible features that pollute the git log; rebasing PRs and using a fast-forwardable merge commit is far superior.

[jseminck]

I don't think any changes have been done in master that affect this. Will check!