Check parentheses with new lines for multiline JSX #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Oct 17, 2017
ljharb
reviewed
Oct 18, 2017
| }, { | ||
| code: ARROW_SINGLE_LINE, | ||
| options: [] |
There was a problem hiding this comment.
should we not keep this test against "the default"?
| code: ARROW_PAREN, | ||
| options: [] |
There was a problem hiding this comment.
should we not keep this test against "the default"?
There was a problem hiding this comment.
The two tests above these are using the defaults.
lencioni
approved these changes
Oct 30, 2017
|
Looks like this needs a rebase |
This changes the options from a boolean to an enum with five possible values: true, false, `ignore`, `parens`, and `parens-new-line`. True and false are there for backwards compatibility. Using `ignore` equates to using `false` while `parens` is equal to `true`. The new option (`parens-new-line`) will check that the parentheses around the multiline JSX are on separate lines for better readability.
This was referenced Nov 18, 2017
This was referenced Dec 15, 2017
This was referenced Feb 2, 2018
Open
This was referenced Feb 2, 2018
This was referenced Sep 22, 2018
This was referenced Oct 25, 2018
1 task
1 task
1 task
This was referenced Dec 21, 2018
This was referenced Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the options from a boolean to an enum with three possible
values:
ignore,parens, andparens-new-line. Usingignoreis likethe previous
falsewhileparensis like the previoustrue. The newoption (
parens-new-line) will check that the parentheses around themultiline JSX are on separate lines for better readability.
This PR attempts to address #1469.