Fix boolean-prop-naming with Object.spread syntax
#1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Oct 17, 2017
track0x1
force-pushed
the
fix-boolean-prop-naming-spread
branch
from
515cfb5
to
2d4a73c
Compare
track0x1
force-pushed
the
fix-boolean-prop-naming-spread
branch
from
2d4a73c
to
67f1cc8
Compare
|
@ljharb Done! |
This was referenced Dec 15, 2017
This was referenced Feb 2, 2018
Open
This was referenced Sep 22, 2018
1 task
1 task
1 task
1 task
This was referenced Dec 21, 2018
This was referenced Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue where using Object.spread syntax with this rule causes Eslint to break as it attempts to look for
node.value.propertyin a spread object. We avoid validating spread nodes by checking for theExperimentalSpreadPropertytype.Reopened #1482 (github wasn't showing new commit) @ljharb