Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace node.start/node.end with node.range[0]/node.range[1], respectively #1496

Merged
merged 1 commit into from Oct 24, 2017
Merged

Replace node.start/node.end with node.range[0]/node.range[1], respectively #1496

merged 1 commit into from Oct 24, 2017

Conversation

timothykang
Copy link
Contributor

Usage of non-standard .start/.end properties causes failures when they aren't set by some parsers that follow the official AST (e.g. typescript-eslint-parser).

See: eslint/eslint#8956

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, seems reasonable.

@ljharb ljharb merged commit e9e33cf into jsx-eslint:master Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants