Handle no-props-unused-props in custom validators #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petersendidit
force-pushed
the
1068-fix
branch
from
72d3d67
to
0e976b9
Compare
ljharb
requested changes
Nov 6, 2017
| static propTypes = { | ||
| validate: PropTypes.bool, | ||
| options: PropTypes.array, | ||
| value: function ({options, value, validate}) { |
There was a problem hiding this comment.
can you also add a test case for value({options, value, validate}) {?
There was a problem hiding this comment.
👍 Added the test case.
petersendidit
force-pushed
the
1068-fix
branch
from
0e976b9
to
2b4776a
Compare
When a custom prop validator is used mark props used inside the validator as used. Fixes jsx-eslint#1068
ljharb
approved these changes
Nov 6, 2017
|
Will merge this tomorrow if no objections. |
This was referenced Dec 15, 2017
This was referenced Feb 2, 2018
Open
This was referenced Sep 22, 2018
This was referenced Oct 25, 2018
1 task
1 task
1 task
This was referenced Dec 21, 2018
This was referenced Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a custom prop validator is used mark props used inside the
validator as used.
Fixes #1068