Add a rule enforcing explicit "type" attributes for buttons #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm open to renaming it BTW, maybe |
ljharb
requested changes
Nov 9, 2017
There was a problem hiding this comment.
This should also validate that the type is one of submit, button, or reset.
Also, it would be ideal to configure each separately, since Airbnb would always forbid using reset, which is horrific for UX.
Can this perhaps not just apply to jsx, and also apply to React.createElement?
|
As for the name, |
Are there some examples of rules that check both JSX and |
|
I'll give this a day, and then merge if there's no objections. |
This was referenced Nov 11, 2017
jzaefferer
added a commit
to sevenval/eslint-plugin-react
that referenced
this pull request
Nov 13, 2017
Looks like a copy&pasta error. Ref jsx-eslint#1525
jzaefferer
added a commit
to sevenval/eslint-plugin-react
that referenced
this pull request
Nov 13, 2017
Looks like a copy&pasta error. Ref jsx-eslint#1525
Closed
This was referenced Dec 15, 2017
This was referenced Feb 2, 2018
Open
This was referenced Sep 22, 2018
This was referenced Oct 25, 2018
1 task
1 task
1 task
This was referenced Dec 21, 2018
This was referenced Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default,
buttonelements havetype="submit", which usually isn't what you actually want. This rule enforces the button type to be explicitSee also: https://github.com/evcohen/eslint-plugin-jsx-a11y/issues/186#issuecomment-283727911