Code clean up #1526
Merged
Code clean up #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the oldest supported version of `babel-eslint` (6.x) has the key property on ClassProperty nodes, the workarounds aren't needed.
ljharb
reviewed
Nov 9, 2017
lib/util/props.js
Outdated
| /** | ||
| * Checks if the PropTypes MemberExpression node passed in declares a required propType. | ||
| * @param {ASTNode} propTypeExpression node to check. Must be a `PropTypes` MemberExpression. | ||
| * @returns {Boolean} `true` if this PropType is required, `false` if not. |
There was a problem hiding this comment.
i think we can remove all these extra spaces; it's not aligned anyways
lib/util/props.js
Outdated
| /** | ||
| * Checks if the Identifier node passed in looks like a defaultProps declaration. | ||
| * @param {ASTNode} node The node to check. Must be an Identifier node. | ||
| * @returns {Boolean} `true` if the node is a defaultProps declaration, `false` if not |
|
This is really great. There's a lot of duplicate code between prop-types and no-unused-prop-types rules that should be extracted out. I think this is a good first step. 👍 |
ljharb
approved these changes
Nov 9, 2017
EvHaus
approved these changes
Nov 11, 2017
This was referenced Dec 15, 2017
This was referenced Feb 2, 2018
Open
This was referenced Sep 22, 2018
This was referenced Sep 23, 2018
This was referenced Oct 25, 2018
1 task
1 task
1 task
This was referenced Dec 21, 2018
This was referenced Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous times I have made changes, I have noticed some duplication in code and wanted to deduplicate it. I have started that in this PR, and I wanted to open it up for some feedback. Is this desired? Should I go further?