jsx-no-target-blank to check for forms with target="_blank"

[jaaberg]

This should fix #1143.

I am not sure if this should be an option or not (as suggested in the issue)(?).

[ljharb]

Yes, let’s please put this behind an option, such that “a” and “form” can be separately controlled, but “a” defaults to being checked and “form” does not. That way, it’ll be semver-minor instead of semver-major.

[jaaberg]

Added option preventInForms to opt-in to validating target-blank in forms with tests and docs.

[ljharb]

@jaaberg what about a schema like this:

{
  "forms": <boolean>, // default false
  "links": <boolean>, // default true
}

That way it's an easy change to flip the default from false to true in the next semver-major, and the schema is also extensible if we want to add other categories in the future?

[jaaberg]

@ljharb Thanks for feedback :) Updated the PR.

[ljharb]

LGTM, thanks!

[ljharb]

!config.links || node.parent.name.name !== 'a'?

[jaaberg]

Yeah I was thinking about it, do you think it is more readable?

[ljharb]

hm, i'm not really sure. i'm not a fan of ternaries that select booleans, but as-is might be more readable in this case.

[EvHaus]

LGTM. Great test coverage on this MR.

[ljharb]

Rebased, and added a global formComponents setting to go with the linkComponents setting that was added after this PR was created.

[ljharb]

@jaaberg i think this can land if it's rebased on top of the newly added allowReferrer and warnOnSpreadAttributes options.

[codecov-commenter]

Codecov Report

Merging #1617 (2705431) into master (30ae98b) will decrease coverage by 0.12%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #1617      +/-   ##
==========================================
- Coverage   97.49%   97.37%   -0.13%     
==========================================
  Files         111      111              
  Lines        7396     7423      +27     
  Branches     2700     2714      +14     
==========================================
+ Hits         7211     7228      +17     
- Misses        185      195      +10     

Impacted Files	Coverage Δ
lib/rules/jsx-no-target-blank.js	87.61% <82.00%> (-7.19%)	⬇️
lib/util/linkComponents.js	95.23% <90.00%> (-4.77%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30ae98b...2705431. Read the comment docs.