Support recursive type annotations, fixes #913 #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally written by @phpnode as part of jsx-eslint#1138
ljharb
reviewed
Jan 26, 2018
lib/rules/prop-types.js
Outdated
| @@ -466,11 +466,22 @@ module.exports = { | |||
| * @return {Object} The representation of the declaration, empty object means | |||
| * the property is declared without the need for further analysis. | |||
| */ | |||
| function buildTypeAnnotationDeclarationTypes(annotation) { | |||
| function buildTypeAnnotationDeclarationTypes(annotation, seen) { | |||
| if (seen === void 0) { | |||
There was a problem hiding this comment.
typeof seen === 'undefined' please :-) either way, there's no need for void 0 in code that only runs in a node environment.
ljharb
approved these changes
Jan 27, 2018
This was referenced Jan 29, 2018
This was referenced Feb 2, 2018
Open
Closed
This was referenced Sep 22, 2018
This was referenced Oct 25, 2018
This was referenced Nov 7, 2018
This was referenced Nov 23, 2018
1 task
1 task
This was referenced Dec 21, 2018
This was referenced Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally written by @phpnode as part of #1138
That PR was closed in favor of #1377, which does not appear to include a solution for the recursive type definition issue.
This allows for code like
to run without triggering an infinite loop.