Fixed crossorigin naming convention and missing tag support. #1659
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzDev
changed the title
This was referenced Jan 26, 2018
ljharb
requested changes
Jan 27, 2018
| @@ -80,14 +80,8 @@ ruleTester.run('no-unknown-property', rule, { | |||
| code: '<rect clip-path="bar" />;', | |||
| output: '<rect clipPath="bar" />;', | |||
| errors: [{message: 'Unknown property \'clip-path\' found, use \'clipPath\' instead'}] | |||
| }, { | |||
| code: '<script crossOrigin />', | |||
There was a problem hiding this comment.
let's replace this with crossorigin, so that it tests that this is an invalid property?
ljharb
force-pushed
the
jzDev/flip-crossorigin-rule
branch
from
6fa13ae to
1d13218
Compare
This was referenced Jan 29, 2018
This was referenced Jan 31, 2018
This was referenced Feb 2, 2018
1 task
1 task
This was referenced Dec 21, 2018
This was referenced Jan 2, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed crossorigin naming convention to match React's supported HTML attributes.
https://reactjs.org/docs/dom-elements.html
Fixes #1656. Per #1642 (comment)