Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error location #1666

Merged
merged 1 commit into from Feb 1, 2018
Merged

Fix error location #1666

merged 1 commit into from Feb 1, 2018

Conversation

pfhayes
Copy link
Contributor

@pfhayes pfhayes commented Jan 30, 2018

Fixes #1660

<a>bar</a>
</App>
`,
code: `<App>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this kind of seems like you maybe ran prettier on the output; could you revert all those unrelated changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is related in the sense that I wanted to remove extraneous whitespace from the test cases, so that the loc test assertions were more predictable and were not affected by the indentation of the surrounding code

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having code: `\n seems like it achieves that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not positive I understand, but I updated this to make it clearer. the indentation is still flush with column 1 so that the column counts are fixed, but the code samples now begin with a newline which may help with readability

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense :-) rebased, will merge soon.

@ljharb ljharb force-pushed the errorloc branch 2 times, most recently from 7736c09 to 05c49d4 Compare January 31, 2018 22:54
@ljharb ljharb added the bug label Jan 31, 2018
@ljharb ljharb merged commit 05c49d4 into jsx-eslint:master Feb 1, 2018
This was referenced Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants