Fixed "PropType is defined but prop is never used react/no-unused-prop-types"

[yuri-sakharov]

We got PropType is defined but prop is never used react/no-unused-prop-types when used createReactClass.
Added fix, tests and removed 2 duplicated tests.

[ljharb]

Thanks! For each of the tests you added (that use babel-eslint), could you add duplicate tests that use the default parser?

[yuri-sakharov]

Yes, of course.

[yuri-sakharov]

Added requested tests.

[yuri-sakharov]

@ljharb what about this case:

class Hello extends Component {
          static propTypes = {
            something: PropTypes.bool
          }
          componentWillUpdate (nextProps, nextState) {
            const {something} = nextProps;
          }
        }

does it should throw error or not?

[ljharb]

That syntax requires babel-eslint; but we should have a test with the default parser that covers Hello.propTypes = { … } instead.

[yuri-sakharov]

@ljharb is it the same

code: [
        'var Hello = createReactClass({',
        '  propTypes: {',
        '    something: PropTypes.bool,',
        '  },',
        '  componentWillReceiveProps (nextProps) {',
        '    const {something} = nextProps;',
        '    doSomething(something);',
        '  }',
        '})'
      ].join('\n'),
      parser: 'babel-eslint'

and

code: [
        'var Hello = createReactClass({',
        '  propTypes: {',
        '    something: PropTypes.bool,',
        '  },',
        '  componentWillReceiveProps (nextProps) {',
        '    const {something} = nextProps;',
        '    doSomething(something);',
        '  }',
        '})'
      ].join('\n')

?
will all use parser: 'babel-eslint'?

[ljharb]

yep, those all look the same :-)