Update no-unused-prop-types rule for new React class component lifecycles #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Feb 8, 2018
lib/rules/no-unused-prop-types.js
Outdated
| 'componentDidUpdate', | ||
| 'componentWillReceiveProps', | ||
| 'componentWillUpdate', | ||
| 'getDerivedStateFromProps', |
There was a problem hiding this comment.
these new methods should only be checked if the React version pragma from settings is >= 16.3.
There was a problem hiding this comment.
Ah, yes. Thanks for pointing that out.
bvaughn
force-pushed
the
update-no-unused-prop-types
branch
from
9b47c5b
to
c0c7ce0
Compare
|
Can we get this PR merged ? |
|
I checked the PR and it works. Could you please merge this PR? |
This was referenced May 12, 2018
cemjotform
added a commit
to jotform/jotform-linter-configs
that referenced
this pull request
Jun 28, 2018
The change is related to the following bug jsx-eslint/eslint-plugin-react#1681
This was referenced Sep 22, 2018
This was referenced Sep 23, 2018
Open
This was referenced Oct 25, 2018
This was referenced Nov 23, 2018
1 task
1 task
This was referenced Dec 21, 2018
This was referenced Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upcoming React 16.3 release will make a couple of changes to the class component lifecycles:
componentWillMount,componentWillReceiveProps, andcomponentWillUpdateare being aliased toUNSAFE_componentWillMount,UNSAFE_componentWillReceiveProps, andUNSAFE_componentWillUpdateand a new static lifecycle,getDerivedStateFromProps, is being added.For background information, see RFC 6.
When running codemods at Facebook to rename these lifecycles, I noticed that it caused a couple of false positives with the
react/no-unused-prop-typeslint rule since that rule was not yet aware of the lifecycle changes. I think this PR corrects that. I added a couple of sanity check tests (which failed before my changes) to verify this.