Support createClass in no-typos #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Jun 16, 2018
| if (propertyName === 'propTypes' || propertyName === 'contextTypes' || propertyName === 'childContextTypes') { | ||
| checkValidPropObject(node); | ||
| } | ||
| STATIC_CLASS_PROPERTIES.forEach(CLASS_PROP => { | ||
| if (propertyName && CLASS_PROP.toLowerCase() === propertyName.toLowerCase() && CLASS_PROP !== propertyName) { | ||
| const message = isClassProperty | ||
| ? 'Typo in static class property declaration' |
There was a problem hiding this comment.
i think it's fine to have different messages, but "static class property" is a conceptual term prior to the feature landing in the language, so i think that'd be reasonable.
alexzherdev
force-pushed
the
1721-no-typos-create-class
branch
from
07232ad
to
d641900
Compare
ljharb
force-pushed
the
1721-no-typos-create-class
branch
from
d641900
to
7b70462
Compare
1 task
1 task
This was referenced Dec 28, 2018
Closed
This was referenced Jan 4, 2019
Closed
Closed
ghost
mentioned this pull request
This was referenced Jan 13, 2019
Merged
This was referenced Sep 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1721
Also added some more tests for good measure.
Not sure about the exact message for an ES5 component, but mentioning
static class propertydidn't make sense.