For deprecated lifecycle methods, report identifier AST node instead of the class node #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he class node When the `no-deprecated` rule finds a deprecated lifecycle method, it reports the whole class declaration as the AST node for the error. Doesn't look good in editor and hides all other ESLint errors inside the class. This patch changes the reported AST node to the method name identifier. The errors are much better targeted at the infringing code and look much better when shown in editor UI. Added also test coverage to check for the reported AST node type.
ljharb
approved these changes
Jun 26, 2018
|
@ljharb Thanks for reviewing this patch! I added a commit with line/column/endLine/endColumn checks. |
|
@jsnajdr looks like eslint 3 is failing on the |
|
Oops, ESLint 3 apparently didn't support the |
This was referenced Aug 14, 2018
Merged
This was referenced Sep 22, 2018
Closed
This was referenced Oct 21, 2018
This was referenced Oct 30, 2018
This was referenced Nov 23, 2018
1 task
1 task
1 task
This was referenced Dec 21, 2018
This was referenced Dec 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
no-deprecatedrule finds a deprecated lifecycle method, it reports the whole class declaration as the AST node for the error. Doesn't look good in editor: makes the whole class declaration red and obscures all other ESLint errors inside the class.This patch changes the reported AST node to the method name identifier. The errors are much better targeted at the infringing code and look much better when shown in editor UI.
Added also test coverage to check for the reported AST node type.