Stop crashing on undefined or null properties in flow intersection #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to other fix for flow intersection (jsx-eslint#1806)
ljharb
requested changes
Jun 28, 2018
|
I have added the cases from the two issues |
ljharb
approved these changes
Jul 4, 2018
This was referenced Aug 14, 2018
Merged
This was referenced Sep 22, 2018
Closed
This was referenced Oct 21, 2018
This was referenced Oct 30, 2018
This was referenced Nov 23, 2018
1 task
1 task
1 task
This was referenced Dec 21, 2018
This was referenced Dec 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to other fix for flow intersection (#1806). I am not sure if this is the correct fix but the change stops Eslint crashing.
Fixes #1770
Fixes #1631