Handle member expressions in jsx-props-no-multi-spaces #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexzherdev
commented
Jul 20, 2018
| case 'JSXIdentifier': | ||
| return propNode.name; | ||
| case 'JSXMemberExpression': | ||
| return `${propNode.object.name}.${propNode.property.name}`; |
There was a problem hiding this comment.
This will not handle Foo.Bar.Baz, do we need that?
There was a problem hiding this comment.
I think it should handle dots, yes - and if bracket notation is supported, that too (but i don’t think it is)
There was a problem hiding this comment.
Do you mean Foo['Bar']? Yeah, looks like it's not supported according to Babel REPL.
There was a problem hiding this comment.
To clarify; it should handle any number of nested member expressions.
There was a problem hiding this comment.
I hope recursion is good enough for practical uses 😄
ljharb
approved these changes
Jul 20, 2018
| @@ -114,5 +116,11 @@ ruleTester.run('jsx-props-no-multi-spaces', rule, { | |||
| errors: [ | |||
| {message: 'Expected only one space between "Foo.Bar" and "baz"'} | |||
| ] | |||
| }, { | |||
| code: '<Foobar.Foo.Bar.Baz.Qux.Quux.Quuz.Corge.Grault.Garply.Waldo.Fred.Plugh xyzzy="thud" />', | |||
There was a problem hiding this comment.
This test has been eaten by a grue.
ljharb
force-pushed
the
1881-no-multi-spaces-undefined
branch
from
fda7ea3
to
2aa0955
Compare
This was referenced Aug 14, 2018
Merged
This was referenced Sep 22, 2018
Closed
This was referenced Oct 21, 2018
This was referenced Oct 30, 2018
This was referenced Nov 23, 2018
1 task
1 task
1 task
This was referenced Dec 21, 2018
This was referenced Dec 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1881