Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Components.get ignore components with confidence = 0 #1907

Merged

Conversation

alexzherdev
Copy link
Contributor

@alexzherdev alexzherdev commented Jul 28, 2018

Resolves #1637
Resolves #1800

@alexzherdev

This comment has been minimized.

@ljharb ljharb added the bug label Jul 28, 2018
@ljharb
Copy link
Member

ljharb commented Jul 28, 2018

I suspect this might also fix a number of other bugs around rules too-greedily warning on non-components. Would you mind checking the open issues and seeing if there's additional test cases that could apply here?

@alexzherdev
Copy link
Contributor Author

Oh yes, I remember at least seeing #1800 which seems to be the same issue that's being fixed here. Will check that and others.

@alexzherdev
Copy link
Contributor Author

alexzherdev commented Jul 29, 2018

Added tests for the original issue in #1800, plus #1800 (comment)
I had high hopes for #512, but since that returns createElement, it gets a non-zero confidence value.
(and Travis failure is a fluke again)

@ljharb ljharb merged commit efe0c0c into jsx-eslint:master Jul 29, 2018
@alexzherdev alexzherdev deleted the 1637-destructuring-assignment-greedy branch July 29, 2018 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants