New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full example in react/jsx-no-target-blank #1988
Conversation
docs/rules/jsx-no-target-blank.md
Outdated
@@ -18,6 +18,13 @@ There are two main options for the rule: | |||
* `{"enforceDynamicLinks": "always"}` enforces the rule if the href is a dynamic link (default) | |||
* `{"enforceDynamicLinks": "never"}` does not enforce the rule if the href is a dynamic link | |||
|
|||
```json | |||
"react/jsx-no-target-blank": [<enabled>, { enforceDynamicLinks: <enforce> }] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the key needs to be quoted, since it's json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
docs/rules/jsx-no-target-blank.md
Outdated
``` | ||
|
||
* enabled: for enabling the rule. 0=off, 1=warn, 2=error. Defaults to 0. | ||
* enforce: optional string, defaults to "always" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems redundant, since it's on lines 18-19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, I'm following how it works on some other pages
Made that change. I looked at some of the other docs more carefully, and reordered the Rule Options so hopefully it makes a bit more sense. |
See #1986
I found the docs a bit unclear, so I've added a fuller example, hopefully in line with other examples.