Update no-typos rule to check static lifecycle methods #2006
Conversation
| }, { | ||
| code: ` | ||
| class Hello extends React.Component { | ||
| getDerivedStateFromProps() { } |
There was a problem hiding this comment.
let's please add a "valid" rule for static getDerivedStateFromProps, and also an invalid one for static getDERIVEDStateFromProps :-)
There was a problem hiding this comment.
I added a test to check that static getDerivedStateFromProps is valid.
Regarding the second, there is already a test that checks static GetDerivedStateFromProps is invalid. Is it necessary to check static getDERIVEDStateFromProps too?
There was a problem hiding this comment.
as long as the checks cover a) the proper spelling and capitalization, b) any miscapitalization, c) any misspelling, and then those three with 1) static and 2) instance, then we should be good.
|
@bsonntag i've rebased this; the tests are still failing. are you still interested in completing this PR? |
|
@ljharb not really, sorry. |
This updates the `no-typos` rule so that it checks for lifecycle methods that should be static, like `getDerivedStateFromProps`.
This updates the
"no-typos"rule so that it checks for lifecycle methods that should be static, likegetDerivedStateFromProps.Closes #1999