Fix no-unused-state crash #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't assume `classInfo.aliases` is a set since there are some cases where it is `null` for a `ClassProperty`.
jomasti
commented
Dec 28, 2018
| // Don't error out | ||
| code: ` | ||
| class Foo extends Component { | ||
| handleChange = function() { |
There was a problem hiding this comment.
This and the next test case were what I could find that would reproduce the error. It seems like weird usages, but it won't error out.
This was referenced Jan 1, 2019
Closed
This was referenced Jan 7, 2019
Closed
ghost
mentioned this pull request
This was referenced Jan 13, 2019
Merged
This was referenced Sep 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't assume
classInfo.aliasesis a set since there are some cases whereit is
nullfor aClassProperty.Fixes #2096