Fix false positives inside lifecycle methods #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will prevent triggering on any member expression inside a lifecycle method. Instead, it will do the naive checking of the node names for `props`, `nextProps`, and `prevProps` which is already done here.
alexzherdev
reviewed
Dec 28, 2018
| @@ -285,13 +285,14 @@ module.exports = function usedPropTypesInstructions(context, components, utils) | |||
| * @returns {Boolean} True if we are using a prop, false if not. | |||
| */ | |||
| function isPropTypesUsage(node) { | |||
| const isThisPropsUsage = node.object.type === 'ThisExpression' && node.property.name === 'props'; | |||
| const isPropsUsage = isThisPropsUsage || node.object.name === 'nextProps' || node.object.name === 'prevProps'; | |||
There was a problem hiding this comment.
Thanks for the fix!
Later on it'd be great not to depend on the names (similar to #1829), but for now not crashing is the priority 👍
ljharb
approved these changes
Dec 30, 2018
|
Hi! Thanks so much for your work on this plugin. We're running into this issue at badges/shields#2609. Could this be released? |
|
v7.12.1 is released. |
This was referenced Jan 1, 2019
Closed
This was referenced Jan 7, 2019
Closed
ghost
mentioned this pull request
This was referenced Jan 13, 2019
Merged
This was referenced Sep 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent triggering on any member expression inside a lifecycle
method. Instead, it will do the naive checking of the node names for
props,nextProps, andprevPropswhich is already done here.Resolves #2094. Resolves #2095.