Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for template literals in no-string-refs rule #2167

Merged
merged 2 commits into from Feb 18, 2019

Conversation

jenil94
Copy link
Contributor

@jenil94 jenil94 commented Feb 15, 2019

This PR aims to fix #2148.

no-string-ref will throw warning when using template literals in string refs.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this seems great.

However, I think it'd be safer if we put this check behind an option, so as to avoid a major change.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great!

It might be nice in a followup PR to make all the attribute cases autofixable :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

no-string-refs: template strings are ignored
2 participants