Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsx-sort-default-props] Bug fix for one case with spread #2182

Merged
merged 1 commit into from Mar 13, 2019
Merged

[jsx-sort-default-props] Bug fix for one case with spread #2182

merged 1 commit into from Mar 13, 2019

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Feb 28, 2019

Closes #2178

I thought an option was needed, but instead it was a bug

@VincentLanglet VincentLanglet changed the title Fix case with spread [jsx-sort-default-props] Bug fix for one case with spread Feb 28, 2019
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great, pending one change :-)

lib/rules/jsx-sort-default-props.js Outdated Show resolved Hide resolved
@ljharb ljharb added the bug label Mar 7, 2019
@VincentLanglet
Copy link
Contributor Author

@ljharb Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants