test(jsx-curly-spacing): test against fixed in the past bug #2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Mar 17, 2019
tests/lib/rules/jsx-curly-spacing.js
Outdated
| '<div onLayout={() => { /* dummy callback to fix android bug with component measuring */ }} />' | ||
| ].join('\n'), | ||
| options: ['never', {allowMultiline: true}], | ||
| errors: [] |
There was a problem hiding this comment.
If this has no errors, it should be in the “valid” section, not the “invalid” section
There was a problem hiding this comment.
oh, sorry! didn't noticed that there is "valid" section
removed that test and added test into valid section
ljharb
force-pushed
the
998-jsx-curly-spacing-regression-test
branch
from
279fce9
to
005070d
Compare
1 task
This was referenced Sep 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #998