Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate boolean prop names nested deeper #2234

Merged
merged 1 commit into from Apr 12, 2019

Conversation

pawelnvk
Copy link
Contributor

@pawelnvk pawelnvk commented Apr 10, 2019

Prop names nested inside of shape weren't validated. Issue shouldn't occur.

Closes #2041.

@ljharb
Copy link
Member

ljharb commented Apr 11, 2019

This looks good, but I’m concerned about suddenly causing more warnings for people. Can we put this behind an option?

@pawelnvk
Copy link
Contributor Author

Ok. Now it should work with option.

@ljharb ljharb merged commit 157332f into jsx-eslint:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

The rule boolean-prop-naming does not check nested props.
2 participants