Skip to content

[fix]prop-types: fix case with destructuring and default param #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2019

Conversation

golopot
Copy link
Contributor

@golopot golopot commented Apr 20, 2019

fixes #2241

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband
@ljharb ljharb changed the title [fix]prop-types: fix case with destructuring and defualt param [fix]prop-types: fix case with destructuring and default param Apr 28, 2019
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see a few more test cases but this looks great!

@ljharb ljharb merged commit 861fdef into jsx-eslint:master Apr 28, 2019
@golopot
Copy link
Contributor Author

golopot commented Apr 28, 2019

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

prop-types not enforced with destructured props and default empty object param
2 participants